[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452862#comment-16452862
]
Plamen Jeliazkov commented on HDFS-13399:
-----------------------------------------
Hey [~shv],
Yes there was some misunderstanding. I was under the impression from the
comment here that you were implying those changes were safe OK to keep in; just
a mistake on my end:
https://issues.apache.org/jira/browse/HDFS-13399?focusedCommentId=16448937&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16448937.
I went ahead and removed nearly all the changes from {{NameNodeProxies}} now.
The only change I had to do was that {{NameNodeProxies.createNonHAProxy}} calls
into {{NameNodeProxiesClient.createNonHAProxyWithClientProtocol}}. Since
{{NameNodeProxiesClient.createNonHAProxyWithClientProtocol}} takes
{{AlignmentContext}} I made the {{NameNodeProxies}} call simply pass null. We
can overload the {{NameNodeProxiesClient.createNonHAProxyWithClientProtocol}}
call if you want to have zero changes to {{NameNodeProxies}}.
The changes within {{NameNodeProxiesClient}} are necessary to keep because of
{{ClientHAProxyFactory}} class calls it, which extends {{HAProxyFactory}}
interface. {{HAProxyFactory}} change caused us to change
{{NameNodeHAProxyFactory}} which is how I ended up modifying
{{NameNodeProxies}}.
I hope this new patch will clear things up now. Please take a look and let me
know.
> Make Client field AlignmentContext non-static.
> ----------------------------------------------
>
> Key: HDFS-13399
> URL: https://issues.apache.org/jira/browse/HDFS-13399
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-12943
> Reporter: Plamen Jeliazkov
> Assignee: Plamen Jeliazkov
> Priority: Major
> Attachments: HDFS-13399-HDFS-12943.000.patch,
> HDFS-13399-HDFS-12943.001.patch, HDFS-13399-HDFS-12943.002.patch,
> HDFS-13399-HDFS-12943.003.patch, HDFS-13399-HDFS-12943.004.patch,
> HDFS-13399-HDFS-12943.005.patch
>
>
> In HDFS-12977, DFSClient's constructor was altered to make use of a new
> static method in Client that allowed one to set an AlignmentContext. This
> work is to remove that static field and make each DFSClient pass it's
> AlignmentContext down to the proxy Call level.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
