[
https://issues.apache.org/jira/browse/HDFS-13399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446514#comment-16446514
]
Konstantin Shvachko commented on HDFS-13399:
--------------------------------------------
# It seems to me that {{createNonHAProxy()}} does not generally need
{{AlignmentContext}}, because without HA there are no Standbys and therefore no
Observers. Should we remove those changes?
# I think it is incorrect to add {{AlignmentContext}} to
{{AbstractNNFailoverProxyProvider}}, which is inherited by all ProxyProviders.
Some ProxyProvider are meant to talk to single NN only, so the
{{AlignmentContext}} should be present exclusively in
{{StandbyReadProxyProvider}} for now. If you need this for testing, then you
should be able to define in the tests some
{{TestProxyProviderWithAlignmentContext}} derived from whatever variant of
ProxyProvider you need, and use it there.
> Make Client field AlignmentContext non-static.
> ----------------------------------------------
>
> Key: HDFS-13399
> URL: https://issues.apache.org/jira/browse/HDFS-13399
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-12943
> Reporter: Plamen Jeliazkov
> Assignee: Plamen Jeliazkov
> Priority: Major
> Attachments: HDFS-13399-HDFS-12943.000.patch,
> HDFS-13399-HDFS-12943.001.patch, HDFS-13399-HDFS-12943.002.patch
>
>
> In HDFS-12977, DFSClient's constructor was altered to make use of a new
> static method in Client that allowed one to set an AlignmentContext. This
> work is to remove that static field and make each DFSClient pass it's
> AlignmentContext down to the proxy Call level.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
