[
https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487757#comment-16487757
]
Arpit Agarwal commented on HDDS-90:
-----------------------------------
Thanks for the patch [~bharatviswa]. My comments below:
# Can you add a couple of lines to FIRST_LAYOUT_VERSION to describe what the
layout looks like on disk? Also perhaps we can use a more descriptive name than
FIRST_LAYOUT_VERSION.
# Should the {{createContainer}} call be a part of the {{Container}}
interface? Sounds like it should be a part of ContainerSet.
# deleteContainer, updateContainer, readContainer, closeContainer can be
renamed to delete, update, read, close etc. since they are already part of the
Container interface.
# Could you clarify the javadoc for readContainer? Does it read the
containerData from disk? If it is returning from memory perhaps we can just
call it getContainerData().
# Let's make the javadoc on ContainerData class little more descriptive. We
can say something like _ContainerData is the in-memory representation of
container metadata and is represented on disk by the .container file._
# Comments like the following can be removed as they don't give much useful
info:
{code:java}
/**
* Construct ContainerData object.
*/
{code}
# Make immutable fields of ContainerData final.
# Do we need {{ContainerData#setContainerType}}? I assume this is immutable
once the object is constructed.
# Can you add a brief comment to describe what {{ContainerData#metadata}} is
expected to hold?
# Similar comments for KeyValueContainerData. Let's improve class Javadocs for
this and also KeyValueContainer.
> Create ContainerData, Container classes
> ---------------------------------------
>
> Key: HDDS-90
> URL: https://issues.apache.org/jira/browse/HDDS-90
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-90-HDDS-48.01.patch, HDDS-90.00.patch
>
>
> This Jira is to create following classes:
> ContainerData (to have generic fields for different types of containers)
> KeyValueContainerData (To extend ContainerData and have fields specific to
> KeyValueContainer)
> Container (For Container meta operations)
> KeyValueContainer(To extend Container)
>
> In this Jira implementation of KeyValueContainer is not done, as this
> requires volume classes.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
