[
https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491291#comment-16491291
]
Anu Engineer commented on HDDS-90:
----------------------------------
Really good improvement to the current code. Thank you for getting this done. I
am +1 , on this patch. Some minor comments, feel free to address them in this
Jira or in the follow up JIRAs.
1. DatanodeContainerProtocol.proto:
{{// This is used for create Container Request.}}
I don't see this used in the create request.
2. nit: ChunkLayoutVersion.java -
NO_CHECKSUM_WITH_DATA, since this is description we can rewrite this as "Data
without checksums."
3. ContainerData.java
{{/** parameters for read/write statistics on the container. **/}}
I hope we are not presisting I/O stats in the .container file.
> Create ContainerData, Container classes
> ---------------------------------------
>
> Key: HDDS-90
> URL: https://issues.apache.org/jira/browse/HDDS-90
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-90-HDDS-48.01.patch, HDDS-90-HDDS-48.02.patch,
> HDDS-90-HDDS-48.03.patch, HDDS-90-HDDS-48.04.patch, HDDS-90-HDDS-48.05.patch,
> HDDS-90.00.patch
>
>
> This Jira is to create following classes:
> ContainerData (to have generic fields for different types of containers)
> KeyValueContainerData (To extend ContainerData and have fields specific to
> KeyValueContainer)
> Container (For Container meta operations)
> KeyValueContainer(To extend Container)
>
> In this Jira implementation of KeyValueContainer is not done, as this
> requires volume classes.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
