[ 
https://issues.apache.org/jira/browse/HDDS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488214#comment-16488214
 ] 

Bharat Viswanadham commented on HDDS-90:
----------------------------------------

Hi [~arpitagarwal] Thanks for review.

Addressed all of your review comments.

 
 # 
{quote}Should the {{createContainer}} call be a part of the {{Container}} 
interface? Sounds like it should be a part of ContainerSet.{quote}creation of 
container will be specific for the container, as for KeyValue type we create a 
DB file for the container. So, I think this is specific for the container. Let 
me know if I am missing something here.

> Create ContainerData, Container classes
> ---------------------------------------
>
>                 Key: HDDS-90
>                 URL: https://issues.apache.org/jira/browse/HDDS-90
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-90-HDDS-48.01.patch, HDDS-90-HDDS-48.02.patch, 
> HDDS-90.00.patch
>
>
> This Jira is to create following classes:
> ContainerData (to have generic fields for different types of containers)
> KeyValueContainerData (To extend ContainerData and have fields specific to 
> KeyValueContainer)
> Container (For Container meta operations)
> KeyValueContainer(To extend Container)
>  
> In this Jira implementation of KeyValueContainer is not done, as this 
> requires volume classes.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to