[
https://issues.apache.org/jira/browse/HDFS-13631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493986#comment-16493986
]
Íñigo Goiri edited comment on HDFS-13631 at 5/29/18 6:09 PM:
-------------------------------------------------------------
Thanks [~bharatviswa] for the explanation.
I think we should rely on the class MiniDFSCluster, otherwise we get the issue
reported in this JIRA.
Let's make the following here:
# Make the number of DNs a constant instead of just a 2.
# Make {{testCheckNumOfBlocksInReportCommand}} use the mini cluster from the
class; this should be just a matter of summing all the DNs in line 936 instead
of hardcoding to 0.
# Make the base MiniDFSCluster use a random path (not a fix by itself but it
would help running parallel unit tests and these kind of conflicts in the
future).
was (Author: elgoiri):
Thanks [~bharatviswa] for the explanation.
I think we should rely on the class MiniDFSCluster, otherwise we get the issue
reported in this JIRA.
Let's make two things here:
# Make the number of DNs a constant instead of just a 2.
# Make {{testCheckNumOfBlocksInReportCommand}} use the mini cluster from the
class; this should be just a matter of summing all the DNs in line 936 instead
of hardcoding to 0.
# Make the base MiniDFSCluster use a random path (not a fix by itself but it
would help running parallel unit tests and these kind of conflicts in the
future).
> TestDFSAdmin#testCheckNumOfBlocksInReportCommand should use a separate
> MiniDFSCluster path
> ------------------------------------------------------------------------------------------
>
> Key: HDFS-13631
> URL: https://issues.apache.org/jira/browse/HDFS-13631
> Project: Hadoop HDFS
> Issue Type: Test
> Reporter: Anbang Hu
> Assignee: Anbang Hu
> Priority: Minor
> Labels: Windows
> Attachments: HDFS-13631.000.patch
>
>
> [TestDFSAdmin#testCheckNumOfBlocksInReportCommand|https://builds.apache.org/job/hadoop-trunk-win/479/testReport/org.apache.hadoop.hdfs.tools/TestDFSAdmin/testCheckNumOfBlocksInReportCommand/]
> fails with error message:
> {color:#d04437}Could not fully delete
> F:\short\hadoop-trunk-win\s\hadoop-hdfs-project\hadoop-hdfs\target\test\data\3\dfs\name-0-1{color}
> because testCheckNumOfBlocksInReportCommand is starting a new MiniDFSCluster
> with the same base path as the one in @Before
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
