[ 
https://issues.apache.org/jira/browse/HDFS-13631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495966#comment-16495966
 ] 

Bharat Viswanadham edited comment on HDFS-13631 at 5/31/18 1:34 AM:
--------------------------------------------------------------------

Thank You [~huanbang1993]  for the patch and [~elgoiri] for proposal and 
improving test case.

Approach LGTM. 

+1.

Ya, instead of heartbeat sleep, we can change it to wait until for a specified 
time, and check whether we reached block count or not. I am okay with 
addressing the issue in another jira.

 

 


was (Author: bharatviswa):
Approach LGTM. 

+1.

Ya, instead of heartbeat sleep, we can change it to wait until for a specified 
time, and check whether we reached block count or not. I am okay with 
addressing the issue in another jira.

 

 

> TestDFSAdmin#testCheckNumOfBlocksInReportCommand should use a separate 
> MiniDFSCluster path
> ------------------------------------------------------------------------------------------
>
>                 Key: HDFS-13631
>                 URL: https://issues.apache.org/jira/browse/HDFS-13631
>             Project: Hadoop HDFS
>          Issue Type: Test
>            Reporter: Anbang Hu
>            Assignee: Anbang Hu
>            Priority: Minor
>              Labels: Windows
>         Attachments: HDFS-13631.000.patch, HDFS-13631.001.patch
>
>
> [TestDFSAdmin#testCheckNumOfBlocksInReportCommand|https://builds.apache.org/job/hadoop-trunk-win/479/testReport/org.apache.hadoop.hdfs.tools/TestDFSAdmin/testCheckNumOfBlocksInReportCommand/]
>  fails with error message:
> {color:#d04437}Could not fully delete 
> F:\short\hadoop-trunk-win\s\hadoop-hdfs-project\hadoop-hdfs\target\test\data\3\dfs\name-0-1{color}
> because testCheckNumOfBlocksInReportCommand is starting a new MiniDFSCluster 
> with the same base path as the one in @Before



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to