[
https://issues.apache.org/jira/browse/HDFS-13631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495981#comment-16495981
]
Íñigo Goiri edited comment on HDFS-13631 at 5/31/18 2:01 AM:
-------------------------------------------------------------
Thanks [~bharatviswa] for the review.
Yes, I think we can leave the sleep business for the future.
The unit tests passed
[here|https://builds.apache.org/job/PreCommit-HDFS-Build/24334/testReport/org.apache.hadoop.hdfs.tools/TestDFSAdmin/].
The test passed in 5 seconds, so it could use some optimization but I think if
we go for optimizing we may want to target {{testListOpenFiles}} as it takes 27
seconds.
Anyway, let's open a separate JIRA to improve the whole test.
[^HDFS-13631.001.patch] doesn't include the randomized path.
[~huanbang1993] can we add that?
was (Author: elgoiri):
Thanks [~bharatviswa] for the review.
Yes, I think we can leave the sleep business for the future.
The unit tests passed
[here|https://builds.apache.org/job/PreCommit-HDFS-Build/24334/testReport/org.apache.hadoop.hdfs.tools/TestDFSAdmin/].
The test passed in 5 seconds, so it could use some optimization but I think if
we go for optimizing we may want to target {{testListOpenFiles}} as it takes 27
seconds.
Anyway, let's open a separate JIRA to improve the whole test.
+1 on [^HDFS-13631.001.patch].
Committing.
> TestDFSAdmin#testCheckNumOfBlocksInReportCommand should use a separate
> MiniDFSCluster path
> ------------------------------------------------------------------------------------------
>
> Key: HDFS-13631
> URL: https://issues.apache.org/jira/browse/HDFS-13631
> Project: Hadoop HDFS
> Issue Type: Test
> Reporter: Anbang Hu
> Assignee: Anbang Hu
> Priority: Minor
> Labels: Windows
> Attachments: HDFS-13631.000.patch, HDFS-13631.001.patch
>
>
> [TestDFSAdmin#testCheckNumOfBlocksInReportCommand|https://builds.apache.org/job/hadoop-trunk-win/479/testReport/org.apache.hadoop.hdfs.tools/TestDFSAdmin/testCheckNumOfBlocksInReportCommand/]
> fails with error message:
> {color:#d04437}Could not fully delete
> F:\short\hadoop-trunk-win\s\hadoop-hdfs-project\hadoop-hdfs\target\test\data\3\dfs\name-0-1{color}
> because testCheckNumOfBlocksInReportCommand is starting a new MiniDFSCluster
> with the same base path as the one in @Before
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
