[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499913#comment-16499913
]
Yiqun Lin commented on HDFS-13641:
----------------------------------
Thanks for addressing the comments, [~csun]. Almost looks good, two minor
comments:
* Can we use {{edit logs tailing}} to replace {{edit log loading}} for metrics
{{editLogLoadInterval}} and {{editLogLoadTime}} 's comment. This will be
consistent with that documented in metric doc.
* Please remove following unnecessary change.
{code:java}
- public void addStorageBlockReport(long latency) {
- storageBlockReport.add(latency);
- for (MutableQuantiles q : storageBlockReportQuantiles) {
- q.add(latency);
- }
- }
-
public void addCacheBlockReport(long latency) {
cacheReport.add(latency);
for (MutableQuantiles q : cacheReportQuantiles) {
@@ -389,4 +407,35 @@ public void addResourceCheckTime(long latency) {
q.add(latency);
}
}
+
+ public void addStorageBlockReport(long latency) {
+ storageBlockReport.add(latency);
+ for (MutableQuantiles q : storageBlockReportQuantiles) {
+ q.add(latency);
+ }
+ }
{code}
> Add metrics for edit log tailing
> ---------------------------------
>
> Key: HDFS-13641
> URL: https://issues.apache.org/jira/browse/HDFS-13641
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: metrics
> Reporter: Chao Sun
> Assignee: Chao Sun
> Priority: Major
> Attachments: HDFS-13641-HDFS-12943.000.patch, HDFS-13641.000.patch
>
>
> We should add metrics for each iteration of edit log tailing, including 1) #
> of edits loaded, 2) time spent in select input edit stream, 3) time spent in
> loading the edits, 4) interval between the iterations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
