[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500788#comment-16500788
]
Erik Krogen commented on HDFS-13641:
------------------------------------
Thanks for addressing the comments [~csun]! I think we had a misunderstanding
over what I meant about the Javadoc for {{assertQuantileGauges}}; I was trying
to say that we should document that "Latency" is used as the default for the
two-arg version.
Two nits on the {{Metrics.md}} documentation:
* The descriptions for the new {{NumOps}} metrics read a bit strange, e.g. for
{{EditLogTailTimeNumOps}} it should probably read more like "Total number of
times the standby namenode tailed the edit log." Similar improvements could be
made for the other NumOps metrics.
* Can we capitalize NameNode throughout these descriptions?
> Add metrics for edit log tailing
> ---------------------------------
>
> Key: HDFS-13641
> URL: https://issues.apache.org/jira/browse/HDFS-13641
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: metrics
> Reporter: Chao Sun
> Assignee: Chao Sun
> Priority: Major
> Attachments: HDFS-13641-HDFS-12943.000.patch, HDFS-13641.000.patch,
> HDFS-13641.001.patch
>
>
> We should add metrics for each iteration of edit log tailing, including 1) #
> of edits loaded, 2) time spent in select input edit stream, 3) time spent in
> loading the edits, 4) interval between the iterations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
