[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500569#comment-16500569
]
Chao Sun commented on HDFS-13641:
---------------------------------
Thanks [~linyiqun] and [~xkrogen] for the very helpful comments!
[~linyiqun]:
bq. Can we use edit logs tailing to replace edit log loading for metrics
editLogLoadInterval and editLogLoadTime 's comment. This will be consistent
with that documented in metric doc.
Done
bq. Please remove following unnecessary change.
Oops this is not inteneded. Done.
[~xkrogen]:
bq. The changes to make assertQuantileGauges more general are good. I think
leaving the default as "Latency" is probably a good idea, but let's document
that in the Javadoc.
Sure. Added a few text explaining what the parameter {{'valueName'}} is for.
bq. For the startTime within doWork(), I think it should be fetched after
locking the namespace, to avoid lock queue delays appearing as part of the load
time.
Done.
Also, yes good idea to also add {{MutableRate}} for these metrics. I see
similar things are done for a few other metrics too, such as {{cacheReport}}.
Will do that.
Curious: do you know roughly how much performance hit it would be by turning on
percentiles on NN?
> Add metrics for edit log tailing
> ---------------------------------
>
> Key: HDFS-13641
> URL: https://issues.apache.org/jira/browse/HDFS-13641
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: metrics
> Reporter: Chao Sun
> Assignee: Chao Sun
> Priority: Major
> Attachments: HDFS-13641-HDFS-12943.000.patch, HDFS-13641.000.patch
>
>
> We should add metrics for each iteration of edit log tailing, including 1) #
> of edits loaded, 2) time spent in select input edit stream, 3) time spent in
> loading the edits, 4) interval between the iterations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
