[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501028#comment-16501028
]
Chen Liang commented on HDFS-12976:
-----------------------------------
Thanks for the quick followup [~csun]! I'm perfectly fine with doing this in
separate Jiras.
Just two more minor comments then:
1. ObserverReadProxyProvider#invoke has comment {{"Sends read operations to the
first observer"}}, maybe change to something like {{"observer specified by
currentIndex"}}?
2. HATestUtil#configureObserverReadFs, seems to be sharing most of the lines
with {{configureFailoverFs}}, may be simplify to just set the configure key
{{PROXY_PROVIDER_KEY_PREFIX}} then call into configureFailoverFs?
Other than these, I'm +1 on the patch. Since this is a rather tricky and
important change, [~shv] do you mind also taking a look?
> Introduce StandbyReadProxyProvider
> ----------------------------------
>
> Key: HDFS-12976
> URL: https://issues.apache.org/jira/browse/HDFS-12976
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Konstantin Shvachko
> Assignee: Chao Sun
> Priority: Major
> Attachments: HDFS-12976.WIP.patch
>
>
> {{StandbyReadProxyProvider}} should implement {{FailoverProxyProvider}}
> interface and be able to submit read requests to ANN and SBN(s).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
