[ 
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505080#comment-16505080
 ] 

Chao Sun commented on HDFS-12976:
---------------------------------

Thanks [~vagarychen]! I addressed most of your comments except this one:

bq. HATestUtil#configureObserverReadFs, seems to be sharing most of the lines 
with configureFailoverFs, may be simplify to just set the configure key 
PROXY_PROVIDER_KEY_PREFIX then call into configureFailoverFs?

The reason for the sharing is that {{setFailoverConfigurations}} inside 
{{configureFailoverFs}} will overwrite the config and set it to the existing 
{{ConfiguredFailoverProxyProvider}} class. We can change that function to 
accept an extra parameter about the class but it also involves many changes, 
since it is heavily overloaded.


> Introduce StandbyReadProxyProvider
> ----------------------------------
>
>                 Key: HDFS-12976
>                 URL: https://issues.apache.org/jira/browse/HDFS-12976
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Konstantin Shvachko
>            Assignee: Chao Sun
>            Priority: Major
>         Attachments: HDFS-12976.WIP.patch
>
>
> {{StandbyReadProxyProvider}} should implement {{FailoverProxyProvider}} 
> interface and be able to submit read requests to ANN and SBN(s).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to