[
https://issues.apache.org/jira/browse/HDFS-12716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526374#comment-16526374
]
Brahma Reddy Battula commented on HDFS-12716:
---------------------------------------------
Thanks for updating the patch.Almost LGTM apart from the following minor nits.
1) can you extract "-1" to one variable and use same.
2) "should be lesh than -1" extract to one constant and use same.and message
should be corrected with "greater than".
> 'dfs.datanode.failed.volumes.tolerated' to support minimum number of volumes
> to be available
> ---------------------------------------------------------------------------------------------
>
> Key: HDFS-12716
> URL: https://issues.apache.org/jira/browse/HDFS-12716
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Reporter: usharani
> Assignee: Ranith Sardar
> Priority: Major
> Attachments: HDFS-12716.002.patch, HDFS-12716.patch
>
>
> Currently 'dfs.datanode.failed.volumes.tolerated' supports number of
> tolerated failed volumes to be mentioned. This configuration change requires
> restart of datanode. Since datanode volumes can be changed dynamically,
> keeping this configuration same for all may not be good idea.
> Support 'dfs.datanode.failed.volumes.tolerated' to accept special
> 'negative value 'x' to tolerate failures of upto "n-x"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
