[
https://issues.apache.org/jira/browse/HDFS-12716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547558#comment-16547558
]
Yiqun Lin commented on HDFS-12716:
----------------------------------
Hi [~RANith], I don't think the latest patch are fully addressed the review
comments from [~brahmareddy].
Can you update this
{noformat}
public int maxVolumeFailureLimit = -1;
public String maxVolumeFailuresToleratedmsg = "should be greater than -1";
{noformat}
to
{noformat}
public static final int MAX_VOLUME_FAILURE_LIMIT = -1;
public static final String MAX_VOLUME_FAILURES_TOLERATED_MSG = "should be
greater than -1";
{noformat}
And put them in one class (like in DataNode)and reuse them in other places.
> 'dfs.datanode.failed.volumes.tolerated' to support minimum number of volumes
> to be available
> ---------------------------------------------------------------------------------------------
>
> Key: HDFS-12716
> URL: https://issues.apache.org/jira/browse/HDFS-12716
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Reporter: usharani
> Assignee: Ranith Sardar
> Priority: Major
> Attachments: HDFS-12716.002.patch, HDFS-12716.003.patch,
> HDFS-12716.004.patch, HDFS-12716.patch
>
>
> Currently 'dfs.datanode.failed.volumes.tolerated' supports number of
> tolerated failed volumes to be mentioned. This configuration change requires
> restart of datanode. Since datanode volumes can be changed dynamically,
> keeping this configuration same for all may not be good idea.
> Support 'dfs.datanode.failed.volumes.tolerated' to accept special
> 'negative value 'x' to tolerate failures of upto "n-x"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
