[
https://issues.apache.org/jira/browse/HDFS-12716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527109#comment-16527109
]
Yiqun Lin commented on HDFS-12716:
----------------------------------
Thanks [~RANith] for working on this! In addition [~brahmareddy]'s review
comments, some comments from me:
*
{code:java}
- if (maxVolumeFailuresTolerated >= dataDirs.size()) {
+ if (maxVolumeFailuresTolerated != -1
+ && maxVolumeFailuresTolerated >= dataDirs.size()) {
throw new DiskErrorException("Invalid value configured for "
+ DFS_DATANODE_FAILED_VOLUMES_TOLERATED_KEY + " - "
+ maxVolumeFailuresTolerated + ". Value configured is >= "
@@ -213,12 +214,22 @@ public StorageLocationChecker(Configuration conf, Timer
timer)
}
}
{code}
The condition check {{maxVolumeFailuresTolerated != -1}} is redundant here
since if {{maxVolumeFailuresTolerated}} is -1 ,it will never large than data
dir size.
* Please document the meaning of value -1 for
{{dfs.datanode.failed.volumes.tolerated}} in hdfs-default.xml. People won't
know this value can be configured or what's the meaning for -1 to be configured.
> 'dfs.datanode.failed.volumes.tolerated' to support minimum number of volumes
> to be available
> ---------------------------------------------------------------------------------------------
>
> Key: HDFS-12716
> URL: https://issues.apache.org/jira/browse/HDFS-12716
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Reporter: usharani
> Assignee: Ranith Sardar
> Priority: Major
> Attachments: HDFS-12716.002.patch, HDFS-12716.patch
>
>
> Currently 'dfs.datanode.failed.volumes.tolerated' supports number of
> tolerated failed volumes to be mentioned. This configuration change requires
> restart of datanode. Since datanode volumes can be changed dynamically,
> keeping this configuration same for all may not be good idea.
> Support 'dfs.datanode.failed.volumes.tolerated' to accept special
> 'negative value 'x' to tolerate failures of upto "n-x"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
