[
https://issues.apache.org/jira/browse/HDFS-13848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591005#comment-16591005
]
Konstantin Shvachko commented on HDFS-13848:
--------------------------------------------
Good catch with first two points, [~vagarychen].
For three the reasons are:
# In the {{IPFailoverProxyProvider}} constructor {{nnProxyInfo}} is only
initialized with the (single) NameNode address. Otherwise I will need to store
the URI in an extra member, which I tried to avoid.
# Also it falls into a common pattern with CFPP, where we initialize
{{ProxyInfo}} for each NameNode with its address in the constructor. And then
create the actual proxy when needed in {{getProxy()}}.
> Refactor NameNode failover proxy providers
> ------------------------------------------
>
> Key: HDFS-13848
> URL: https://issues.apache.org/jira/browse/HDFS-13848
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, hdfs-client
> Affects Versions: 2.7.5
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Priority: Major
> Attachments: HDFS-13848-003.patch, HDFS-13848.002.patch,
> HDFS-13848.patch
>
>
> Looking at NN failover proxy providers in the context of HDFS-13782 I noticed
> that {{ConfiguredFailoverProxyProvider}} and {{IPFailoverProxyProvider}} have
> a lot of common logic. We can move this common logic into
> {{AbstractNNFailoverProxyProvider}}, which simplifies things a lot.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
