[
https://issues.apache.org/jira/browse/HDFS-13848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592197#comment-16592197
]
Konstantin Shvachko commented on HDFS-13848:
--------------------------------------------
* {{addressKey}} is a hacky solution introduced in HDFS-13536 for provided
storage. I first thought it was used in some tests. Different address key
should be handled in {{InMemoryAliasMapFailoverProxyProvider}} instead of
spilling it into {{ConfiguredFailoverProxyProvider}}, but oh well. Added
{{addressKey}} to {{getAddresses()}}.
* I think the return value is useful. You can do {{return
createProxyIfNeeded(ip)}} instead of two lines.
* I first made {{getProxyAddresses()}} static, just as you suggest, but then I
realized that I forgot to add delegation token cloning in places where it is
needed, and decided to go with current version.
> Refactor NameNode failover proxy providers
> ------------------------------------------
>
> Key: HDFS-13848
> URL: https://issues.apache.org/jira/browse/HDFS-13848
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, hdfs-client
> Affects Versions: 2.7.5
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Priority: Major
> Attachments: HDFS-13848-003.patch, HDFS-13848-004.patch,
> HDFS-13848.002.patch, HDFS-13848.patch
>
>
> Looking at NN failover proxy providers in the context of HDFS-13782 I noticed
> that {{ConfiguredFailoverProxyProvider}} and {{IPFailoverProxyProvider}} have
> a lot of common logic. We can move this common logic into
> {{AbstractNNFailoverProxyProvider}}, which simplifies things a lot.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
