[
https://issues.apache.org/jira/browse/HDFS-13848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593792#comment-16593792
]
Erik Krogen commented on HDFS-13848:
------------------------------------
{quote}
addressKey is a hacky solution introduced in HDFS-13536 for provided storage. I
first thought it was used in some tests. Different address key should be
handled in InMemoryAliasMapFailoverProxyProvider instead of spilling it into
ConfiguredFailoverProxyProvider, but oh well. Added addressKey to
getAddresses().
{quote}
Yup, agreed that it seems to be a weird solution, but that doesn't mean we
should break it here :) Thanks for taking care of this.
> Refactor NameNode failover proxy providers
> ------------------------------------------
>
> Key: HDFS-13848
> URL: https://issues.apache.org/jira/browse/HDFS-13848
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, hdfs-client
> Affects Versions: 2.7.5
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Priority: Major
> Fix For: 2.10.0, 3.2.0, 2.9.2, 3.0.4, 3.1.2
>
> Attachments: HDFS-13848-003.patch, HDFS-13848-004.patch,
> HDFS-13848-005.patch, HDFS-13848.002.patch, HDFS-13848.patch
>
>
> Looking at NN failover proxy providers in the context of HDFS-13782 I noticed
> that {{ConfiguredFailoverProxyProvider}} and {{IPFailoverProxyProvider}} have
> a lot of common logic. We can move this common logic into
> {{AbstractNNFailoverProxyProvider}}, which simplifies things a lot.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
