[
https://issues.apache.org/jira/browse/HDFS-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605127#comment-16605127
]
Erik Krogen commented on HDFS-13749:
------------------------------------
Right, sorry for the misdirection, the corresponding class in the
hadoop-hdfs-client module is {{NameNodeProxiesClient}}. It seems it doesn't
have a method that we can use out of the box for this, but I think we should
add one to keep such proxy creation logic centralized?
A few other smaller nits:
* Does the proxy creation in {{NNProxyInfo}} actually set up the connection to
be able to throw an {{IOException}}? If so, I think we should lazily
instantiate later rather than in the constructor. As far as I could tell, it
doesn't actually create the connection yet, in which case the current setup is
fine. If you could help me confirm this that would be great.
* {{NNProxyInfo.serviceProto}}, I think this should be called {{serviceProxy}} ?
* In the previous patch, if we were unable to communicate with the NN, we
marked it as STANDBY. I think we should maintain this behavior - your patch
currently leaves the old cached state. I also think the message should be WARN,
not ERROR.
* Rather than using a hard-coded 30 second timeout, can we reuse something
about the configured retry policy?
> Use getServiceStatus to discover observer namenodes
> ---------------------------------------------------
>
> Key: HDFS-13749
> URL: https://issues.apache.org/jira/browse/HDFS-13749
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chao Sun
> Assignee: Chao Sun
> Priority: Major
> Attachments: HDFS-13749-HDFS-12943.000.patch,
> HDFS-13749-HDFS-12943.001.patch
>
>
> In HDFS-12976 currently we discover NameNode state by calling
> {{reportBadBlocks}} as a temporary solution. Here, we'll properly implement
> this by using {{HAServiceProtocol#getServiceStatus}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
