[
https://issues.apache.org/jira/browse/HDFS-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607294#comment-16607294
]
Erik Krogen commented on HDFS-13749:
------------------------------------
Nice, I think this looks great, [~csun]!
I see one small issue besides the unit test failure and checkstyle. In the
{{NNProxyInfo}} constructor, you have the log statement:
{code}
LOG.error("{} Failed to create HAServiceProtocol proxy to NameNode" +
" at {}", this.getClass().getSimpleName(), address, ioe);
{code}
I think you are trying to log the specific subclass of
{{AbstractNNFailoverProxyProvider}}, but since this is within {{NNProxyInfo}},
{{this.getClass()}} will always be {{NNProxyInfo}}, so I don't think it is very
helpful. Let me know if I'm wrong here.
> Use getServiceStatus to discover observer namenodes
> ---------------------------------------------------
>
> Key: HDFS-13749
> URL: https://issues.apache.org/jira/browse/HDFS-13749
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chao Sun
> Assignee: Chao Sun
> Priority: Major
> Attachments: HDFS-13749-HDFS-12943.000.patch,
> HDFS-13749-HDFS-12943.001.patch, HDFS-13749-HDFS-12943.002.patch
>
>
> In HDFS-12976 currently we discover NameNode state by calling
> {{reportBadBlocks}} as a temporary solution. Here, we'll properly implement
> this by using {{HAServiceProtocol#getServiceStatus}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
