[
https://issues.apache.org/jira/browse/HDFS-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16615391#comment-16615391
]
Erik Krogen commented on HDFS-13749:
------------------------------------
Nice, v003 looks good to me [~csun]. A few minor nits:
* There are a few outstanding checkstyle. It looks like the checkstyle thinks
the switch-case should be intended differently. I think I was the one who
actually committed it wrong initially but can we fix it here?
* Within {{createNonHAProxyWithHAServiceProtocol}}, is there any rational
behind using 3 retries with 200ms sleep? I think it's probably fine to leave
this hard-coded until we find a reason for it to need to be configurable, but
we should at least document the fact that it comes with retries in the Javadoc,
and consider pulling these values out as constants.
* If you remove the unnecessary type parameter from the
{{IPFailoverProxyProvider}} constructor the line becomes an acceptable length :)
* Very minor nit, I think the line where you create the service proxy looks a
little better like:
{code}
serviceProxy = NameNodeProxiesClient
.createNonHAProxyWithHAServiceProtocol(address, conf);
{code}
> Use getServiceStatus to discover observer namenodes
> ---------------------------------------------------
>
> Key: HDFS-13749
> URL: https://issues.apache.org/jira/browse/HDFS-13749
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chao Sun
> Assignee: Chao Sun
> Priority: Major
> Attachments: HDFS-13749-HDFS-12943.000.patch,
> HDFS-13749-HDFS-12943.001.patch, HDFS-13749-HDFS-12943.002.patch,
> HDFS-13749-HDFS-12943.003.patch
>
>
> In HDFS-12976 currently we discover NameNode state by calling
> {{reportBadBlocks}} as a temporary solution. Here, we'll properly implement
> this by using {{HAServiceProtocol#getServiceStatus}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
