[
https://issues.apache.org/jira/browse/HDDS-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612980#comment-16612980
]
Xiaoyu Yao commented on HDDS-362:
---------------------------------
Thanks [~ajayydv] for working on this. The patch looks good to me overall. Here
are a few comments:
Hdds.proto
Line 176: should we have a enum for deleteBlock op?
BlockManagerImpl.java
Line 435: should we have an interface defined for PreChecks with a (Boolean
check() )instead of hard coded enum for better extensibility? This also avoid
the big switch below.
SCMChillModeManager.java
Line 75: can we consolidate the CHILL_MODE_STATUS with START_REPLICATION into
EXIT_CHILL_MODE? And we might need ENTER_CHILL_MODE so that the Replication
manager and the BlockManager can respond correspondly.
SCMEvents.java
Line 234: Same as above.
TestBlockManager.java
Line 79: scm can be removed.
TestSCMChillModeManager.java
Line 34/35/38: NIT: unused imports.
> Modify functions impacted by SCM chill mode in ScmBlockLocationProtocol
> -----------------------------------------------------------------------
>
> Key: HDDS-362
> URL: https://issues.apache.org/jira/browse/HDDS-362
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-362.00.patch, HDDS-362.01.patch, HDDS-362.02.patch
>
>
> [HDDS-351] adds chill mode state to SCM. When SCM is in chill mode certain
> operations will be restricted for end users. This jira intends to modify
> functions impacted by SCM chill mode in ScmBlockLocationProtocol.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
