[
https://issues.apache.org/jira/browse/HDDS-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614184#comment-16614184
]
Xiaoyu Yao commented on HDDS-362:
---------------------------------
{quote}{quote}Line 75: can we consolidate the CHILL_MODE_STATUS with
START_REPLICATION into EXIT_CHILL_MODE? And we might need ENTER_CHILL_MODE so
that the Replication manager and the BlockManager can respond correspondly.
{quote}
I think both events are separate and might be invoked in different cases. For
example replication process can be stopped/started temporarily by admin
independently of chill mode. Please share if you still think we need to
consolidate them.
{quote}
Thanks for the update, [~ajayydv]. What I mean is the chillModeManager should
have single responsibility to manage/emit chillmodestatus. This way,
ReplicationManager, BlockManager and other component will listening to the same
event instead of redefining their own but respond independently according to
their own logic. The new ChillModePrecheck can also be reused by
BlockManagerImplth and ReplicationActivityStatus.
I feel start/stop replication are SCM internal implementation details, which we
don't want to expose to admin.
> Modify functions impacted by SCM chill mode in ScmBlockLocationProtocol
> -----------------------------------------------------------------------
>
> Key: HDDS-362
> URL: https://issues.apache.org/jira/browse/HDDS-362
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-362.00.patch, HDDS-362.01.patch, HDDS-362.02.patch,
> HDDS-362.03.patch
>
>
> [HDDS-351] adds chill mode state to SCM. When SCM is in chill mode certain
> operations will be restricted for end users. This jira intends to modify
> functions impacted by SCM chill mode in ScmBlockLocationProtocol.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
