[
https://issues.apache.org/jira/browse/HDFS-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622389#comment-16622389
]
Erik Krogen commented on HDFS-13749:
------------------------------------
So for the checkstyle
{code}
proxyProvider = new ObserverReadProxyProvider<ClientProtocol>(conf, nnURI,
ClientProtocol.class, new ClientHAProxyFactory<ClientProtocol>() {
@Override
public ClientProtocol createProxy(Configuration conf,
InetSocketAddress nnAddr, Class<ClientProtocol> xface,
UserGroupInformation ugi, boolean withRetries,
AtomicBoolean fallbackToSimpleAuth) {
return proxyMap.get(nnAddr.toString());
}
}) {
{code}
Since the {{ClientHAProxyFactory}} is within an argument list, there should be
an extra level of indent... but currently it is such that the ending brace
lines up with the top-level. I've attached a v007 patch with indentation that
both the Hadoop checkstyle and my IntelliJ style agree is correct :) It also
renames the parameter {{conf}} to {{config}} in the above snippet to avoid a
field masking checkstyle warning that didn't start getting emitted until I
fixed the other one.
> Use getServiceStatus to discover observer namenodes
> ---------------------------------------------------
>
> Key: HDFS-13749
> URL: https://issues.apache.org/jira/browse/HDFS-13749
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chao Sun
> Assignee: Chao Sun
> Priority: Major
> Attachments: HDFS-13749-HDFS-12943.000.patch,
> HDFS-13749-HDFS-12943.001.patch, HDFS-13749-HDFS-12943.002.patch,
> HDFS-13749-HDFS-12943.003.patch, HDFS-13749-HDFS-12943.004.patch,
> HDFS-13749-HDFS-12943.005.patch, HDFS-13749-HDFS-12943.006.patch,
> HDFS-13749-HDFS-12943.007.patch
>
>
> In HDFS-12976 currently we discover NameNode state by calling
> {{reportBadBlocks}} as a temporary solution. Here, we'll properly implement
> this by using {{HAServiceProtocol#getServiceStatus}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
