[ 
https://issues.apache.org/jira/browse/HDDS-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655233#comment-16655233
 ] 

Elek, Marton commented on HDDS-683:
-----------------------------------

Thanks [~bharatviswa] the patch. I really like that we will have this 
functionality. I have some comments:

1. If I understood well, it should be used as 'ozone sh path 
o3://localhost/s3bucketname'. I think it could be confusing as usually the o3 
addresses are starting with volume and not bucket name. I would use just the 
bucket name. Especially as this call is not supported with rest protocol. 
(http://localhost/s3bucketname doesn't work)

2. For me the name 'path' is confusing. It seems to be a generic utility but it 
works only for s3 buckets. There are two options here (IMHO):

a) create an s3 subcommand (ozone s3 ...) which also could be used to set the 
access keys (later)

b) Make this call generic to work for all the buckets. It requires a minor 
modification on the server side (use bucket  -> volume map instead of s3bucket 
-> volume/bucket) but after that it could be handled in the same generic way. I 
strongly prefer this approach.

3. It's very minor, but I think it should be in the volume package instead of 
bucket package. Other similar commands are there.

> Add a shell command to provide ozone mapping for a S3Bucket 
> ------------------------------------------------------------
>
>                 Key: HDDS-683
>                 URL: https://issues.apache.org/jira/browse/HDDS-683
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>             Fix For: 0.3.0, 0.4.0
>
>         Attachments: HDDS-683.00.patch, HDDS-683.01.patch
>
>
> Add a shell command to getOzoneMapping for a s3Bucket. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to