[ 
https://issues.apache.org/jira/browse/HDFS-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675084#comment-16675084
 ] 

Jiandan Yang  commented on HDFS-14045:
--------------------------------------

Hi, [~cheersyang],[~elgoiri] and [~xkrogen]
Thanks very much for your review and comments. 

To [~cheersyang] 
This patch works under HA,  non-HA situation and federation.
Different clusters have different namespaceID, so namespaceID is not suitable 
as metric name. 
I think the most reasonable method is add some tags in metric level, but only 
metric-source level can allow to add tags, so I use different metric. 
Fortunately, there is no need to add too many metric.

To [~xkrogen] and [~elgoiri]
I'v added some ut about HA and Non-HA in patch002, could you please help 
reviewing this again?.

> Use different metrics in DataNode to better measure latency of 
> heartbeat/blockReports/incrementalBlockReports of Active/Standby NN
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-14045
>                 URL: https://issues.apache.org/jira/browse/HDFS-14045
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>            Reporter: Jiandan Yang 
>            Assignee: Jiandan Yang 
>            Priority: Major
>         Attachments: HDFS-14045.001.patch
>
>
> Currently DataNode uses same metrics to measure rpc latency of NameNode, but 
> Active and Standby usually have different performance at the same time, 
> especially in large cluster. For example, rpc latency of Standby is very long 
> when Standby is catching up editlog. We may misunderstand the state of HDFS. 
> Using different metrics for Active and standby can help us obtain more 
> precise metric data.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to