[
https://issues.apache.org/jira/browse/HDFS-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675782#comment-16675782
]
Íñigo Goiri commented on HDFS-14045:
------------------------------------
Thanks [~yangjiandan] for [^HDFS-14045.002.patch].
* I think we can fix some of the checkstyle issues.
* We should add a javadoc to {{BPServiceActor#isActive()}} linking the concepts
of the active service actor and the one in {{BPOfferService}} to make it easier
to follow once we commit.
* In {{testNNRpcMetricsWithHA}}, why trigger the heartbeat twice?
* There is a comment in testNNRpcMetricsWithHA: {{//rb =
getMetrics(dn.getMetrics().name());}}
* Why set the heartbeat to 3 seconds?
Other than that, the test coverage looks good.
> Use different metrics in DataNode to better measure latency of
> heartbeat/blockReports/incrementalBlockReports of Active/Standby NN
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-14045
> URL: https://issues.apache.org/jira/browse/HDFS-14045
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Jiandan Yang
> Assignee: Jiandan Yang
> Priority: Major
> Attachments: HDFS-14045.001.patch, HDFS-14045.002.patch
>
>
> Currently DataNode uses same metrics to measure rpc latency of NameNode, but
> Active and Standby usually have different performance at the same time,
> especially in large cluster. For example, rpc latency of Standby is very long
> when Standby is catching up editlog. We may misunderstand the state of HDFS.
> Using different metrics for Active and standby can help us obtain more
> precise metric data.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
