[
https://issues.apache.org/jira/browse/HDFS-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676059#comment-16676059
]
Jiandan Yang commented on HDFS-14045:
--------------------------------------
Thanks [~elgoiri] for your review comments.
* I'v add javadoc to {{BPServiceActor#isActive()}} and remove invalid comment
in {{testNNRpcMetricsWithHA}} in patch003.
* About UT what I explain is:
** The purpose to set heartbeat interval to 3000 second is to prevent
bpServiceActor sends heartbeat periodically to NN during running test case, and
bpServiceActor only sends heartbeat once after startup if we don't trigger
heartbeat.
** The purpose to trigger heartbeat twice is to get active NN from heartbeat
response and update metrics. The first trigger is to get active NN from
heartbeat response after one NN transition to active, so one of two service
actors will be update to active actor; The second trigger is to update
HeartbeatsNumOps and HeartbeatsForStandbyNumOps by sending heartbeat to Active
and Standby
> Use different metrics in DataNode to better measure latency of
> heartbeat/blockReports/incrementalBlockReports of Active/Standby NN
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-14045
> URL: https://issues.apache.org/jira/browse/HDFS-14045
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Jiandan Yang
> Assignee: Jiandan Yang
> Priority: Major
> Attachments: HDFS-14045.001.patch, HDFS-14045.002.patch
>
>
> Currently DataNode uses same metrics to measure rpc latency of NameNode, but
> Active and Standby usually have different performance at the same time,
> especially in large cluster. For example, rpc latency of Standby is very long
> when Standby is catching up editlog. We may misunderstand the state of HDFS.
> Using different metrics for Active and standby can help us obtain more
> precise metric data.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
