[
https://issues.apache.org/jira/browse/HDDS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687442#comment-16687442
]
Yiqun Lin commented on HDDS-816:
--------------------------------
Thanks for updating the patch, [~bharatviswa]. The latest proposal looks good
to me, :).
Some review comments for the patch:
* {{OM_METRICS_TEMP_FILE}} can reuse the prefix of om metrics? Making it as
{{OM_METRICS_FILE}} + ".tmp";
* Why not just make the config value {{OZONE_OM_METRICS_SAVE_INTERVAL_DEFAULT}}
as '5min'? It still does the time duration transforming in place.
* Add the new config in ozone-default.xml file.
* Maybe we need to add the case for restarting OzoneManager and then verify if
the metrics are persisted successfully.
Another problem for the key count metric: At the first time, there is no key
count metric file, how to initialize the key metric value? I didn't see this
logic.
> Create OM metrics for bucket, volume, keys
> ------------------------------------------
>
> Key: HDDS-816
> URL: https://issues.apache.org/jira/browse/HDDS-816
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Manager
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Attachments: HDDS-816.00.patch, HDDS-816.01.patch, Metrics for number
> of volumes, buckets, keys.pdf, Proposed Approach.pdf
>
>
> This Jira is used to create the following metrics in Ozone manager.
> # number of volumesÂ
> # number of buckets
> # number of keys
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
