[jira] [Commented] (HDDS-816) Create OM metrics for bucket, volume, keys

[Yiqun Lin (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDDS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690199#comment-16690199
 ] 

Yiqun Lin commented on HDDS-816:
--------------------------------

Thanks [~bharatviswa] for updating the patch. Based on the proposed approach, 
the latest patch almost looks good to me now. 
Minor comments:

* Can we log the exception when saving the metric file?
{code}
} catch (IOException ex) {
+      LOG.error("Unable to write the om Metrics file");
+    }
{code}
* Can we reword this? Looks like the message contains your name.
{code}
 LOG.info("Bharat om stop in stop");
{code}
* Can we add a TODO comment for the metric key count? As [~elek] and 
[~arpitagarwal] mentioned the inaccuracy will be have once there are some 
unclean shutdowns. This can help us revisit and improve this, :).

> Create OM metrics for bucket, volume, keys
> ------------------------------------------
>
>                 Key: HDDS-816
>                 URL: https://issues.apache.org/jira/browse/HDDS-816
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Manager
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>         Attachments: HDDS-816.00.patch, HDDS-816.01.patch, HDDS-816.03.patch, 
> HDDS-816.04.patch, HDDS-816.05.patch, Metrics for number of volumes, buckets, 
> keys.pdf, Proposed Approach.pdf
>
>
> This Jira is used to create the following metrics in Ozone manager.
>  # number of volumes 
>  # number of buckets
>  # number of keys



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org