[
https://issues.apache.org/jira/browse/HDDS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693891#comment-16693891
]
Bharat Viswanadham commented on HDDS-816:
-----------------------------------------
Thank You [~arpitagarwal] for the review.
I have addressed all the review comments, except the below one.
#
{quote}Should _intialized = true_ be set inside the start method itself? Else
the second time you invoke start, initialized will be left to false.{quote}
I think we don't need to this in initialize, as when object is constructed we
call start() and set it to true, and if we again call start(), then we should
not do initialization again, which will be taken care by if (!initialized), as
initialized is set to true.
> Create OM metrics for bucket, volume, keys
> ------------------------------------------
>
> Key: HDDS-816
> URL: https://issues.apache.org/jira/browse/HDDS-816
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Manager
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Attachments: HDDS-816.00.patch, HDDS-816.01.patch, HDDS-816.03.patch,
> HDDS-816.04.patch, HDDS-816.05.patch, HDDS-816.06.patch, HDDS-816.07.patch,
> HDDS-816.08.patch, Metrics for number of volumes, buckets, keys.pdf, Proposed
> Approach.pdf
>
>
> This Jira is used to create the following metrics in Ozone manager.
> # number of volumes
> # number of buckets
> # number of keys
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
