[
https://issues.apache.org/jira/browse/HDFS-13358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16755343#comment-16755343
]
Brahma Reddy Battula commented on HDFS-13358:
---------------------------------------------
[~crh] thanks for updating the patch.
* can we move FederationUtil#newSecretManager to RouterSecretManger itself.?
as it's not util and specfic to routersecuritymanager.
* Looks you missed 'DelegationTokenIdentifier" while creating the secret
Manager. should be like below. public static
AbstractDelegationTokenSecretManager<DelegationTokenIdentifier>
newSecretManager(..)
* Need to have testcases to verify with AuthMethod as token. Please refer
org.apache.hadoop.ipc.TestSaslRPC#testDigestRpc.
* I think, in future we can unify token related API's which are similar now in
NN and router. can ignore now.
* Add testcases based on proxy user also.
can we change following log messages to some more clear..?
{noformat}
LOG.info("Secret manager instance created");
LOG.info("Start zk backed secret manager instance")
{noformat}
> RBF: Support for Delegation Token (RPC)
> ---------------------------------------
>
> Key: HDFS-13358
> URL: https://issues.apache.org/jira/browse/HDFS-13358
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Sherwood Zheng
> Assignee: CR Hota
> Priority: Major
> Attachments: HDFS-13358-HDFS-13891.001.patch,
> HDFS-13358-HDFS-13891.002.patch, HDFS-13358-HDFS-13891.003.patch,
> HDFS-13358-HDFS-13891.004.patch, HDFS-13358-HDFS-13891.005.patch, RBF_
> Delegation token design.pdf
>
>
> HDFS Router should support issuing / managing HDFS delegation tokens.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
