[
https://issues.apache.org/jira/browse/HDDS-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772238#comment-16772238
]
Bharat Viswanadham commented on HDDS-1095:
------------------------------------------
Thank You [~msingh] for this perf improvement fix.
*Few comments:*
#
Line 417 can we move before calling allocateBlocks, and remove the preAllocate
and allocateSize? In this way even if the key length provided is zero, we
allocate at least a block, as we are setting size as scmBlockSize and storing
as keyInfo. (As even now we are doing min(Preallocate, length), so with above
mentioned way, we can remove this logic.
#
And also code comments in allocate locks and in openKey Line 406 needs to be
updated.
#
Can we add a javadoc for newly added method allocateBlocks
#
Update java doc for allocateBlock in
ScmBlockLocationProtocolClientSideTransalatorPB.java and
ScmBlockLocationProtocol.java
#
Setting numBlocks is missing when constructing request object in allocateBlock
in ScmBlockLocationProtocolClientSideTransalatorPB.java.
#
And one more question, do we need to pass this block size from OM to SCM, as we
read from config "ozone.scm.block.size” in OM.
> OzoneManager#openKey should do multiple block allocations in a single SCM rpc
> call
> ----------------------------------------------------------------------------------
>
> Key: HDDS-1095
> URL: https://issues.apache.org/jira/browse/HDDS-1095
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Affects Versions: 0.4.0
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Major
> Fix For: 0.4.0
>
> Attachments: HDDS-1095.001.patch
>
>
> Currently in KeyManagerImpl#openKey, for a large key allocation, multiple
> blocks are allocated in different rpc calls. If the key length is already
> known, then multiple blocks can be allocated in one rpc call to SCM.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
