[ 
https://issues.apache.org/jira/browse/HDDS-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776576#comment-16776576
 ] 

Hadoop QA commented on HDDS-726:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 9 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
15s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 21m 
21s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 17m  
3s{color} | {color:red} root in trunk failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m 
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  5m 
43s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
20m 38s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hadoop-ozone/integration-test {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  6m 
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  4m 
49s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
25s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 7s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 16m 
11s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 16m 11s{color} | 
{color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 16m 11s{color} 
| {color:red} root in the patch failed. {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
3m 21s{color} | {color:orange} root: The patch generated 5 new + 0 unchanged - 
0 fixed = 5 total (was 0) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  5m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 14s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hadoop-ozone/integration-test {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m  
0s{color} | {color:red} hadoop-hdds/server-scm generated 2 new + 0 unchanged - 
0 fixed = 2 total (was 0) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
55s{color} | {color:red} hadoop-ozone/client generated 1 new + 0 unchanged - 0 
fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  4m 
41s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  1m 13s{color} 
| {color:red} common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
36s{color} | {color:green} client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  1m 52s{color} 
| {color:red} server-scm in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
49s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
38s{color} | {color:green} client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
48s{color} | {color:green} ozone-manager in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 10m 26s{color} 
| {color:red} integration-test in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  1m 25s{color} 
| {color:red} tools in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
51s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}147m 13s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdds/server-scm |
|  |  Suspicious comparison of Long references in 
org.apache.hadoop.hdds.scm.block.BlockManagerImpl.lambda$discardContainer$0(Long,
 Long)  At BlockManagerImpl.java:in 
org.apache.hadoop.hdds.scm.block.BlockManagerImpl.lambda$discardContainer$0(Long,
 Long)  At BlockManagerImpl.java:[line 223] |
|  |  Call to 
org.apache.hadoop.hdds.scm.pipeline.PipelineID.equals(java.util.UUID) in 
org.apache.hadoop.hdds.scm.pipeline.PipelineStateMap.lambda$discardPipeline$5(Pipeline,
 PipelineID)  At PipelineStateMap.java:PipelineID)  At 
PipelineStateMap.java:[line 257] |
| FindBugs | module:hadoop-ozone/client |
|  |  instanceof will always return true for all non-null values in 
org.apache.hadoop.ozone.client.io.BlockOutputStreamEntry.getFailedServers(), 
since all org.apache.hadoop.hdds.scm.storage.BlockOutputStream are instances of 
org.apache.hadoop.hdds.scm.storage.BlockOutputStream  At 
BlockOutputStreamEntry.java:for all non-null values in 
org.apache.hadoop.ozone.client.io.BlockOutputStreamEntry.getFailedServers(), 
since all org.apache.hadoop.hdds.scm.storage.BlockOutputStream are instances of 
org.apache.hadoop.hdds.scm.storage.BlockOutputStream  At 
BlockOutputStreamEntry.java:[line 170] |
| Failed junit tests | 
hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient |
|   | hadoop.hdds.scm.container.TestContainerActionsHandler |
|   | hadoop.ozone.client.rpc.TestFailureHandlingByClient |
|   | hadoop.ozone.om.TestOzoneManager |
|   | hadoop.ozone.ozShell.TestOzoneShell |
|   | hadoop.ozone.om.TestScmChillMode |
|   | hadoop.ozone.freon.TestRandomKeyGenerator |
|   | hadoop.ozone.freon.TestFreonWithPipelineDestroy |
|   | hadoop.ozone.freon.TestDataValidate |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | HDDS-726 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12959973/HDDS-726.006.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  cc  |
| uname | Linux 042bbd716212 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 92b1fdc |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| compile | 
https://builds.apache.org/job/PreCommit-HDDS-Build/2358/artifact/out/branch-compile-root.txt
 |
| findbugs | v3.1.0-RC1 |
| compile | 
https://builds.apache.org/job/PreCommit-HDDS-Build/2358/artifact/out/patch-compile-root.txt
 |
| cc | 
https://builds.apache.org/job/PreCommit-HDDS-Build/2358/artifact/out/patch-compile-root.txt
 |
| javac | 
https://builds.apache.org/job/PreCommit-HDDS-Build/2358/artifact/out/patch-compile-root.txt
 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HDDS-Build/2358/artifact/out/diff-checkstyle-root.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDDS-Build/2358/artifact/out/new-findbugs-hadoop-hdds_server-scm.html
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDDS-Build/2358/artifact/out/new-findbugs-hadoop-ozone_client.html
 |
| unit | 
https://builds.apache.org/job/PreCommit-HDDS-Build/2358/artifact/out/patch-unit-hadoop-hdds_common.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HDDS-Build/2358/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HDDS-Build/2358/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HDDS-Build/2358/artifact/out/patch-unit-hadoop-ozone_tools.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDDS-Build/2358/testReport/ |
| Max. process+thread count | 4070 (vs. ulimit of 10000) |
| modules | C: hadoop-hdds/common hadoop-hdds/client hadoop-hdds/server-scm 
hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager 
hadoop-ozone/integration-test hadoop-ozone/tools U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HDDS-Build/2358/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Ozone Client should update SCM to move the container out of allocation path 
> in case a write transaction fails
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HDDS-726
>                 URL: https://issues.apache.org/jira/browse/HDDS-726
>             Project: Hadoop Distributed Data Store
>          Issue Type: Test
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>            Priority: Major
>         Attachments: HDDS-726.000.patch, HDDS-726.001.patch, 
> HDDS-726.002.patch, HDDS-726.003.patch, HDDS-726.004.patch, 
> HDDS-726.005.patch, HDDS-726.006.patch
>
>
> Once an container write transaction fails, it will be marked corrupted. Once 
> Ozone client gets an exception in such case it should tell SCM to move the 
> container out of allocation path. SCM will eventually close the container.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to