[ 
https://issues.apache.org/jira/browse/HDDS-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781525#comment-16781525
 ] 

Shashikant Banerjee commented on HDDS-726:
------------------------------------------

Thanks [~nandakumar131] for the review comments. Patch v10 addresses your 
review comments.
{code:java}
Is there any reason for removing @Before and introducing startCluster method?
{code}
startCluster method is introduced specfically, so that we have clean start and 
shutdown in every test as it tests datanode failures scenarios. With @Before, 
there was some sort race happening with shutdown cluster in one test and start 
cluster for the other test which was leading to failure of certain tests.

> Ozone Client should update SCM to move the container out of allocation path 
> in case a write transaction fails
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HDDS-726
>                 URL: https://issues.apache.org/jira/browse/HDDS-726
>             Project: Hadoop Distributed Data Store
>          Issue Type: Test
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>            Priority: Major
>         Attachments: HDDS-726.000.patch, HDDS-726.001.patch, 
> HDDS-726.002.patch, HDDS-726.003.patch, HDDS-726.004.patch, 
> HDDS-726.005.patch, HDDS-726.006.patch, HDDS-726.007.patch, 
> HDDS-726.008.patch, HDDS-726.009.patch, HDDS-726.010.patch
>
>
> Once an container write transaction fails, it will be marked corrupted. Once 
> Ozone client gets an exception in such case it should tell SCM to move the 
> container out of allocation path. SCM will eventually close the container.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to