[
https://issues.apache.org/jira/browse/HDDS-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781337#comment-16781337
]
Nanda kumar commented on HDDS-726:
----------------------------------
[~shashikant], thanks for updating the patch.
Few more comments:
BlockOutputStreamEntry:L169 - Possible {{NullPointerException}}
*PipelineStateMap#discardDatanode*
We are only checking the first datanode in the pipeline with the {{excludeDns}}
list.
{{The pipeline P1[dn1, dn2, dn3] for excludeDns[dn2, dn3] will not be
excluded.}}
XceiverClientReply:L38 - Please add javadoc/comment for the field {{datanodes}}
so that we know these are failed nodes.
*TestFailureHandlingByClient*
Is there any reason for removing {{@Before}} and introducing {{startCluster}}
method?
Nitpick L282, L342, L404 & L468- {{assertFalse}} can be replaced with
{{assertNotEquals}}
Nitpick L309, L367 & L430 - {{assertTrue}} can be replaced with {{assertEquals}}
L379 & L422 - {{containerIdList}} is never used and can be removed
Nitpick PipelineManager:L58 - rename {{pipelineId}} to {{excludePipelines}}
Can you also fix the checkstyle issues.
> Ozone Client should update SCM to move the container out of allocation path
> in case a write transaction fails
> -------------------------------------------------------------------------------------------------------------
>
> Key: HDDS-726
> URL: https://issues.apache.org/jira/browse/HDDS-726
> Project: Hadoop Distributed Data Store
> Issue Type: Test
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Attachments: HDDS-726.000.patch, HDDS-726.001.patch,
> HDDS-726.002.patch, HDDS-726.003.patch, HDDS-726.004.patch,
> HDDS-726.005.patch, HDDS-726.006.patch, HDDS-726.007.patch,
> HDDS-726.008.patch, HDDS-726.009.patch
>
>
> Once an container write transaction fails, it will be marked corrupted. Once
> Ozone client gets an exception in such case it should tell SCM to move the
> container out of allocation path. SCM will eventually close the container.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
