[ 
https://issues.apache.org/jira/browse/HDFS-13972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790116#comment-16790116
 ] 

Íñigo Goiri commented on HDFS-13972:
------------------------------------

Thanks [~crh] for [^HDFS-13972-HDFS-13891.004.patch].
* Can we extract the ternary in {{RouterWebHdfsMethods#662}}
* Can we check something else than {{assertNotNull()}} in 
{{testCreateCredentials()}}?
* In {{TestRouterSecurityManager#133}}, we should add a space after the {{for}}.
* I think we should avoid the log and throw and just throw in 
{{RouterSecurityManager#verifyToken()}}.
* Why do we have {{RouterSecurityManager#verifyToken()}}; this is only used by 
the test?
* Make {{TestRouterSecurityManager#getUserGroupForTesting}} private and static.

What issues are you facing for using WebHDFS to get a token?
The Router you are getting should already provide a fully initialized HTTP 
server right?
I think we should at least go through the HTTP server.

> RBF: Support for Delegation Token (WebHDFS)
> -------------------------------------------
>
>                 Key: HDFS-13972
>                 URL: https://issues.apache.org/jira/browse/HDFS-13972
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: CR Hota
>            Priority: Major
>         Attachments: HDFS-13972-HDFS-13891.001.patch, 
> HDFS-13972-HDFS-13891.002.patch, HDFS-13972-HDFS-13891.003.patch, 
> HDFS-13972-HDFS-13891.004.patch
>
>
> HDFS Router should support issuing HDFS delegation tokens through WebHDFS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to