[ 
https://issues.apache.org/jira/browse/HDFS-13972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792043#comment-16792043
 ] 

CR Hota commented on HDFS-13972:
--------------------------------

[~elgoiri] 
 I introduced a similar flag as hdfs 
(DFS_ROUTER_DELEGATION_TOKEN_ALWAYS_USE_KEY) to initialize secret manager for 
testing. Using this new flag, all web based token related calls could be wired. 
HDFS-13972-HDFS-13891.005.patch also incorporates your previous review comments.

The only thing I din't change is the below comment. This ternary check also 
exists in current hdfs. Extracting this makes code very verbose as all input 
params to the function are final modifiers.
 * Can we extract the ternary in {{RouterWebHdfsMethods#662}}?

 

> RBF: Support for Delegation Token (WebHDFS)
> -------------------------------------------
>
>                 Key: HDFS-13972
>                 URL: https://issues.apache.org/jira/browse/HDFS-13972
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: CR Hota
>            Priority: Major
>         Attachments: HDFS-13972-HDFS-13891.001.patch, 
> HDFS-13972-HDFS-13891.002.patch, HDFS-13972-HDFS-13891.003.patch, 
> HDFS-13972-HDFS-13891.004.patch, HDFS-13972-HDFS-13891.005.patch, 
> TestRouterWebHDFSContractTokens.java
>
>
> HDFS Router should support issuing HDFS delegation tokens through WebHDFS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to