[
https://issues.apache.org/jira/browse/HDFS-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839872#comment-16839872
]
Chen Liang commented on HDFS-12979:
-----------------------------------
Thanks for the review [~xkrogen].
For the canceling the rest part, I actually missed a {{break}} in v006 patch, I
did mean to break the loop if it is {{InterruptedException}}. Because as you
mentioned in previous comment, if it is {{InterruptedException}}, it could mean
the current checkpointing thread is getting interrupted, then it should not
continue uploading, and in which case the canceling the rest part is needed.
I looked at adding the {{Future<TransferResult>}} to the map entry. The thing
here is not all entries in the map are always valid uploads (i.e. the
non-primary, should stay quiet ones). If we keep all the uploads in the entry
object, we still need a set, or flag the existing uploads to indicate which
ones are valid upload objects, we end up still creating objects anyways. I
found it more semantically readable to create uploads objects each round.
I'm verifying the failed tests, and will upload a patch to resolve the findbugs
warnings.
> StandbyNode should upload FsImage to ObserverNode after checkpointing.
> ----------------------------------------------------------------------
>
> Key: HDFS-12979
> URL: https://issues.apache.org/jira/browse/HDFS-12979
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Konstantin Shvachko
> Assignee: Chen Liang
> Priority: Major
> Attachments: HDFS-12979.001.patch, HDFS-12979.002.patch,
> HDFS-12979.003.patch, HDFS-12979.004.patch, HDFS-12979.005.patch,
> HDFS-12979.006.patch
>
>
> ObserverNode does not create checkpoints. So it's fsimage file can get very
> old making bootstrap of ObserverNode too long. A StandbyNode should copy
> latest fsimage to ObserverNode(s) along with ANN.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
