[
https://issues.apache.org/jira/browse/HDDS-1685?focusedWorklogId=264184&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-264184
]
ASF GitHub Bot logged work on HDDS-1685:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jun/19 22:15
Start Date: 20/Jun/19 22:15
Worklog Time Spent: 10m
Work Description: avijayanhwx commented on pull request #987: HDDS-1685.
Recon: Add support for 'start' query param to containers…
URL: https://github.com/apache/hadoop/pull/987#discussion_r296032651
##########
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/spi/ContainerDBServiceProvider.java
##########
@@ -85,7 +86,8 @@ Integer getCountForForContainerKeyPrefix(
* @return Map of containerID -> containerMetadata.
* @throws IOException
*/
- Map<Long, ContainerMetadata> getContainers(int limit) throws IOException;
+ Map<Long, ContainerMetadata> getContainers(int limit, long start)
Review comment:
According to the implementation, the start key will be skipped if present in
the seek. This is to support a pagination kind of API. Maybe, we can change the
param name to reflect this. Something like previous instead of start?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 264184)
Time Spent: 1h 10m (was: 1h)
> Recon: Add support for "start" query param to containers and containers/{id}
> endpoints
> --------------------------------------------------------------------------------------
>
> Key: HDDS-1685
> URL: https://issues.apache.org/jira/browse/HDDS-1685
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
> Affects Versions: 0.4.0
> Reporter: Vivek Ratnavel Subramanian
> Assignee: Vivek Ratnavel Subramanian
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> * Support "start" query param to seek to the given key in RocksDB.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
