[ 
https://issues.apache.org/jira/browse/HDDS-1685?focusedWorklogId=264185&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-264185
 ]

ASF GitHub Bot logged work on HDDS-1685:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Jun/19 22:15
            Start Date: 20/Jun/19 22:15
    Worklog Time Spent: 10m 
      Work Description: avijayanhwx commented on pull request #987: HDDS-1685. 
Recon: Add support for 'start' query param to containers…
URL: https://github.com/apache/hadoop/pull/987#discussion_r296030739
 
 

 ##########
 File path: 
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/ContainerDBServiceProviderImpl.java
 ##########
 @@ -128,23 +128,53 @@ public Integer getCountForForContainerKeyPrefix(
   }
 
   /**
-   * Use the DB's prefix seek iterator to start the scan from the given
-   * container ID prefix.
+   * Get key prefixes for the given container ID.
    *
    * @param containerId the given containerId.
    * @return Map of (Key-Prefix,Count of Keys).
    */
   @Override
   public Map<ContainerKeyPrefix, Integer> getKeyPrefixesForContainer(
       long containerId) throws IOException {
+    // set the default startKeyPrefix to empty string
+    return getKeyPrefixesForContainer(containerId, "");
 
 Review comment:
   Maybe we can use StringUtils.EMPTY.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 264185)
    Time Spent: 1h 20m  (was: 1h 10m)

> Recon: Add support for "start" query param to containers and containers/{id} 
> endpoints
> --------------------------------------------------------------------------------------
>
>                 Key: HDDS-1685
>                 URL: https://issues.apache.org/jira/browse/HDDS-1685
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: Ozone Recon
>    Affects Versions: 0.4.0
>            Reporter: Vivek Ratnavel Subramanian
>            Assignee: Vivek Ratnavel Subramanian
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> * Support "start" query param to seek to the given key in RocksDB.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to