[
https://issues.apache.org/jira/browse/HDDS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875573#comment-16875573
]
Eric Yang commented on HDDS-1735:
---------------------------------
{quote}Do you use these shell scripts? Based on your comments you prefer to use
plain maven commends. If you don't use the shell script why is it a problem to
improve them? The current maven build is not affected at all....{quote}
If the scripts are offered, then dependencies introduced on the offered
scripts. It would be more difficult to remove the scripts later.
{quote}BTW maven lifecycle model is pretty limited compared to the graph based
approach of gradle. For example if you have more than two type of tests, not
just integration test and unit test, it doesn't fit very well. {quote}
Incorrect assumption, you can use maven profile to trigger different type of
tests. For more comprehensive test suites, it can be written as sub-modules.
This avoid elementary mistakes like:
# adding test artifacts into distribution binaries. e.g. include smoke test in
distribution tarball.
# doing integration test prior to package making.
Maven build life cycle is a production tested process. It would be foolish to
ignore the wisdom in the productive workflow. Gradle provides simplified life
cycle, and it can be powerful to put in the hand of seasoned developer.
However, it doesnot help inexperienced developer to sequence the build
workflow. In the end, gradle project may become just as messy as Ant project,
which maven solved to make the build life cycle more process oriented.
> Create separate unit and integration test executor dev-support script
> ---------------------------------------------------------------------
>
> Key: HDDS-1735
> URL: https://issues.apache.org/jira/browse/HDDS-1735
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> hadoop-ozone/dev-support/checks directory contains multiple helper script to
> execute different type of testing (findbugs, rat, unit, build).
> They easily define how tests should be executed, with the following contract:
> * The problems should be printed out to the console
> * in case of test failure a non zero exit code should be used
>
> The tests are working well (in fact I have some experiments with executing
> these scripts on k8s and argo where all the shell scripts are executed
> parallel) but we need some update:
> 1. Most important: the unit tests and integration tests can be separated.
> Integration tests are more flaky and it's better to have a way to run only
> the normal unit tests
> 2. As HDDS-1115 introduced a pom.ozone.xml it's better to use them instead
> of the magical "am pl hadoop-ozone-dist" trick--
> 3. To make it possible to run blockade test in containers we should use - T
> flag with docker-compose
> 4. checkstyle violations are printed out to the console
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
