[
https://issues.apache.org/jira/browse/HDDS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876644#comment-16876644
]
Eric Yang commented on HDDS-1735:
---------------------------------
[~anu] {quote}Can you point me to an instruction – or documentation that
explain how to even setup Yetus on my Mac ? Ozone avoids all these costly
mistakes that make Hadoop very hard to use. So please don't hamper our efforts
by insisting that we need to go back to Hadoop tool chain if we have a better
experience in place.{quote}
This is documented in
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
Look for the section, Testing your patch. This provides the same testing
procedure as running patch testing with Yetus in Jenkins.
[~elek] {quote}If you see any risk in making safer the existing scripts, please
let me know (with the the definition how can I reproduce the problems,
please).{quote}
Ozone maven javadoc has been failing since March. The percommit build test
triggered acceptance test does not use the same javadoc rules as Hadoop. More
javadoc errors are getting generated without incentive to clean up.
Checkstyle, findbugs, rat plugins, shellcheck, Dockerfile checks are all using
default or relaxed rules sets. This creates more hidden problems in the code
base. Technical debts are building up. This is my reasoning to advice against
using one off shell script to run maven plugin goal without configuring the
plugin configurations.
> Create separate unit and integration test executor dev-support script
> ---------------------------------------------------------------------
>
> Key: HDDS-1735
> URL: https://issues.apache.org/jira/browse/HDDS-1735
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> hadoop-ozone/dev-support/checks directory contains multiple helper script to
> execute different type of testing (findbugs, rat, unit, build).
> They easily define how tests should be executed, with the following contract:
> * The problems should be printed out to the console
> * in case of test failure a non zero exit code should be used
>
> The tests are working well (in fact I have some experiments with executing
> these scripts on k8s and argo where all the shell scripts are executed
> parallel) but we need some update:
> 1. Most important: the unit tests and integration tests can be separated.
> Integration tests are more flaky and it's better to have a way to run only
> the normal unit tests
> 2. As HDDS-1115 introduced a pom.ozone.xml it's better to use them instead
> of the magical "am pl hadoop-ozone-dist" trick--
> 3. To make it possible to run blockade test in containers we should use - T
> flag with docker-compose
> 4. checkstyle violations are printed out to the console
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
