[
https://issues.apache.org/jira/browse/HDDS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877280#comment-16877280
]
Eric Yang commented on HDDS-1735:
---------------------------------
[~anu] {quote}Completely different question.{quote}
The focus is to test code hygiene. Please don't quote out of context to assert
Yetus is only way to test patch.
{quote}Now let us go to findbugs, Do the same – run the findbugs – Then be a
good citizen in the Hadoop world and fix the issues. {quote}
I ran this command to search for findbugs supression from hadoop source code
top level:
{code}
[eyang@localhost hadoop]$ grep -R
edu.umd.cs.findbugs.annotations.SuppressFBWarnings *|grep -v "Binary"
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/AbstractFuture.java:import
edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/VolumeUsage.java:import
edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManager.java:import
edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMPolicyProvider.java:import
edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineStateMap.java:import
edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/checker/AbstractFuture.java:import
edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMPolicyProvider.java:import
edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/OzoneClientAdapterFactory.java:import
edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java:import
edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java:import
edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
{code}
Findbug supression is only used once in HDFS, and none in other projects. It's
a growing occurrence in Ozone project. There is one instance in HDFS because
HDDS-1103 is another gift from Ozone developer.
Hadoop may not have clean findbugs report, but it is transparent. Anyone can
generate the report and fix problems. It is a community effort to keep it
clean. One person might not be enough effort to keep the code clean. Ozone
code base tend to suppress warnings without address some of the code issues in
the proper way. I disagree with the approach to address problems, and the rest
is up to you.
> Create separate unit and integration test executor dev-support script
> ---------------------------------------------------------------------
>
> Key: HDDS-1735
> URL: https://issues.apache.org/jira/browse/HDDS-1735
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> hadoop-ozone/dev-support/checks directory contains multiple helper script to
> execute different type of testing (findbugs, rat, unit, build).
> They easily define how tests should be executed, with the following contract:
> * The problems should be printed out to the console
> * in case of test failure a non zero exit code should be used
>
> The tests are working well (in fact I have some experiments with executing
> these scripts on k8s and argo where all the shell scripts are executed
> parallel) but we need some update:
> 1. Most important: the unit tests and integration tests can be separated.
> Integration tests are more flaky and it's better to have a way to run only
> the normal unit tests
> 2. As HDDS-1115 introduced a pom.ozone.xml it's better to use them instead
> of the magical "am pl hadoop-ozone-dist" trick--
> 3. To make it possible to run blockade test in containers we should use - T
> flag with docker-compose
> 4. checkstyle violations are printed out to the console
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
