[ 
https://issues.apache.org/jira/browse/HDFS-14620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876320#comment-16876320
 ] 

He Xiaoqiao commented on HDFS-14620:
------------------------------------

Thanks [~Huachao], convert this JIRA to subtask of HDFS-14603, 
[^HDFS-14620-HDFS-13891-02.patch] most looks good to me. just some nits,
1. Please fix the checkstyle following Jenkins report, refer to 
https://builds.apache.org/job/PreCommit-HDFS-Build/27121/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
2. the following code segment should replace with lambda.
{code:java}
      user.doAs(new PrivilegedExceptionAction<DisableNameserviceResponse>() {
         @Override
         public DisableNameserviceResponse run()  throws Exception {
{code}
3. fail text in #testNameserviceManagerWithRules may be better to change 
'permission check failure for super user'?

> RBF: when Disable namespace in kerberos with superuser's principal, ERROR 
> appear 'not a super user' 
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-14620
>                 URL: https://issues.apache.org/jira/browse/HDFS-14620
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 3.30
>            Reporter: luhuachao
>            Assignee: luhuachao
>            Priority: Major
>         Attachments: HDFS-14620-HDFS-13891-01.patch, 
> HDFS-14620-HDFS-13891-02.patch, HDFS-14620-HDFS-13891-03.patch
>
>
> use superuser hdfs's principal hdfs-test@EXAMPLE cannot disable namespace 
> with error info below, as the code judge the principal not equals to hdfs, 
> also hdfs is not belong to supergroup.
> {code:java}
> [hdfs@host1 ~]$ hdfs dfsrouteradmin -nameservice disable ns2 nameservice: 
> hdfs-test@EXAMPLE is not a super user at 
> org.apache.hadoop.hdfs.server.federation.router.RouterPermissionChecker.checkSuperuserPrivilege(RouterPermissionChecker.java:136)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to