[
https://issues.apache.org/jira/browse/HDFS-14458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16882301#comment-16882301
]
Rakesh R commented on HDFS-14458:
---------------------------------
Thanks [~PhiloHe] for taking this ahead. Added few comments:
# By default {{dfs.datanode.max.locked.memory}} is zero. Do you wants to
disable in-memory caching if PMem-cache is enabled? If yes, please add a log
message to convey the same. Could you try adding a unit test to automate this
behavior.
{code}
this.memCacheStats = new MemoryCacheStats(0L);
{code}
# I'd prefer to avoid {{if (isPmemCacheEnabled())}} checks inside
FsDatasetCache. How about {{cacheLoader#initialize(this)}} returns {{memStats}}
?
{code}
MemoryCacheStats stats = cacheLoader.initialize(this);
{code}
# Appreciate if you could add unit test the results of PMem stats. Thanks!
> Report pmem stats to namenode
> -----------------------------
>
> Key: HDFS-14458
> URL: https://issues.apache.org/jira/browse/HDFS-14458
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Feilong He
> Assignee: Feilong He
> Priority: Major
> Fix For: 3.3.0
>
> Attachments: HDFS-14458.000.patch, HDFS-14458.001.patch,
> HDFS-14458.002.patch
>
>
> Currently, two important stats should be reported to NameNode: cache used and
> cache capacity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
