[ 
https://issues.apache.org/jira/browse/HDFS-14458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883693#comment-16883693
 ] 

Feilong He commented on HDFS-14458:
-----------------------------------

Thanks [~rakeshr] so much for your futher review on this patch!
 # Yes, this piece of code is unnecessary.
 # I have logged this info in warning level.
 # Yes, the CacheStats of 'DRAM' and 'Pmem' cache can be unified. I think it is 
better to do this refactor work along with LazyWriter Pmem support. 

I have uploaded [^HDFS-14458.005.patch] to fix your comments. Thanks so much!

> Report pmem stats to namenode
> -----------------------------
>
>                 Key: HDFS-14458
>                 URL: https://issues.apache.org/jira/browse/HDFS-14458
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Feilong He
>            Assignee: Feilong He
>            Priority: Major
>             Fix For: 3.3.0
>
>         Attachments: HDFS-14458.000.patch, HDFS-14458.001.patch, 
> HDFS-14458.002.patch, HDFS-14458.003.patch, HDFS-14458.004.patch, 
> HDFS-14458.005.patch
>
>
> Currently, two important stats should be reported to NameNode: cache used and 
> cache capacity. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to