[
https://issues.apache.org/jira/browse/HDFS-14458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883663#comment-16883663
]
Rakesh R commented on HDFS-14458:
---------------------------------
Thanks [~PhiloHe] for the updates. Please take care below comments:
# Remove unused method
{code}
/**
* Check if pmem cache is enabled.
*/
private boolean isPmemCacheEnabled() {
return !cacheLoader.isTransientCache();
}
{code}
# Do we really need this exception handling? This can log repeatedly.
{code}
if (cacheCapacity == 0L) {
throw new IOException("DRAM cache may be disabled. The cache capacity
is 0.");
}
{code}
# We need to unify {{CacheStats}} of 'DRAM' and 'PMem' utilization. I'm OK to
do this separately along with LazyWriter PMem support.
> Report pmem stats to namenode
> -----------------------------
>
> Key: HDFS-14458
> URL: https://issues.apache.org/jira/browse/HDFS-14458
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Feilong He
> Assignee: Feilong He
> Priority: Major
> Fix For: 3.3.0
>
> Attachments: HDFS-14458.000.patch, HDFS-14458.001.patch,
> HDFS-14458.002.patch, HDFS-14458.003.patch, HDFS-14458.004.patch
>
>
> Currently, two important stats should be reported to NameNode: cache used and
> cache capacity.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
