[
https://issues.apache.org/jira/browse/HDDS-1827?focusedWorklogId=295770&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295770
]
ASF GitHub Bot logged work on HDDS-1827:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Aug/19 21:24
Start Date: 15/Aug/19 21:24
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1130: HDDS-1827. Load
Snapshot info when OM Ratis server starts.
URL: https://github.com/apache/hadoop/pull/1130#issuecomment-521802948
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 71 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 5 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 28 | Maven dependency ordering for branch |
| +1 | mvninstall | 596 | trunk passed |
| +1 | compile | 359 | trunk passed |
| +1 | checkstyle | 62 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 793 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 149 | trunk passed |
| 0 | spotbugs | 416 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 608 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 17 | Maven dependency ordering for patch |
| +1 | mvninstall | 533 | the patch passed |
| +1 | compile | 348 | the patch passed |
| +1 | javac | 348 | the patch passed |
| -0 | checkstyle | 35 | hadoop-ozone: The patch generated 7 new + 0
unchanged - 0 fixed = 7 total (was 0) |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 676 | patch has no errors when building and testing
our client artifacts. |
| -1 | javadoc | 88 | hadoop-ozone generated 1 new + 20 unchanged - 0 fixed
= 21 total (was 20) |
| -1 | findbugs | 450 | hadoop-ozone generated 4 new + 0 unchanged - 0 fixed
= 4 total (was 0) |
||| _ Other Tests _ |
| +1 | unit | 412 | hadoop-hdds in the patch passed. |
| -1 | unit | 3714 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 41 | The patch does not generate ASF License warnings. |
| | | 9439 | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-ozone |
| | Found reliance on default encoding in
org.apache.hadoop.ozone.om.ratis.OMRatisSnapshotInfo.loadRatisSnapshotIndex():in
org.apache.hadoop.ozone.om.ratis.OMRatisSnapshotInfo.loadRatisSnapshotIndex():
new java.io.FileReader(File) At OMRatisSnapshotInfo.java:[line 82] |
| | Found reliance on default encoding in
org.apache.hadoop.ozone.om.ratis.OMRatisSnapshotInfo.saveRatisSnapshotToDisk(long):in
org.apache.hadoop.ozone.om.ratis.OMRatisSnapshotInfo.saveRatisSnapshotToDisk(long):
new java.io.FileWriter(File) At OMRatisSnapshotInfo.java:[line 104] |
| | Dereference of the result of readLine() without nullcheck in
org.apache.hadoop.ozone.om.ratis.OMRatisSnapshotInfo.loadRatisSnapshotIndex()
At OMRatisSnapshotInfo.java:readLine() without nullcheck in
org.apache.hadoop.ozone.om.ratis.OMRatisSnapshotInfo.loadRatisSnapshotIndex()
At OMRatisSnapshotInfo.java:[line 88] |
| | Dereference of the result of readLine() without nullcheck in
org.apache.hadoop.ozone.om.ratis.OMRatisSnapshotInfo.loadRatisSnapshotIndex()
At OMRatisSnapshotInfo.java:readLine() without nullcheck in
org.apache.hadoop.ozone.om.ratis.OMRatisSnapshotInfo.loadRatisSnapshotIndex()
At OMRatisSnapshotInfo.java:[line 87] |
| Failed junit tests | hadoop.ozone.client.rpc.TestBlockOutputStream |
| | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption |
| | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory |
| | hadoop.ozone.client.rpc.Test2WayCommitInRatis |
| | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException |
| | hadoop.ozone.client.rpc.TestOzoneRpcClientForAclAuditLog |
| | hadoop.ozone.TestContainerStateMachineIdempotency |
| | hadoop.ozone.client.rpc.TestReadRetries |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1130/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1130 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 120842c5ec46 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 77d102c |
| Default Java | 1.8.0_222 |
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1130/2/artifact/out/diff-checkstyle-hadoop-ozone.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1130/2/artifact/out/diff-javadoc-javadoc-hadoop-ozone.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1130/2/artifact/out/new-findbugs-hadoop-ozone.html
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1130/2/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1130/2/testReport/ |
| Max. process+thread count | 3485 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/common hadoop-ozone/ozone-manager
hadoop-ozone/integration-test U: hadoop-ozone |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1130/2/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 295770)
Time Spent: 50m (was: 40m)
> Load Snapshot info when OM Ratis server starts
> ----------------------------------------------
>
> Key: HDDS-1827
> URL: https://issues.apache.org/jira/browse/HDDS-1827
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When Ratis server is starting it looks for the latest snapshot to load it.
> Even though OM does not save snapshots via Ratis, we need to load the saved
> snaphsot index into Ratis so that the LogAppender knows to not look for logs
> before the snapshot index. Otherwise, Ratis will replay the logs from
> beginning every time it starts up.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
